[Feat] Client LB using gRPC specs #438
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
polvalente
reviewed
Sep 11, 2025
Co-authored-by: Paulo Valente <16843419+polvalente@users.noreply.github.com>
polvalente
reviewed
Sep 11, 2025
Comment on lines
+71
to
+79
| @doc """ | ||
| Initialization for resolvers. | ||
|
|
||
| Calls `resolver_module.start(args)` and returns its result. | ||
| """ | ||
| @spec start_resolver(module(), args :: term()) :: :ok | {:ok, pid()} | {:error, term()} | ||
| def start_resolver(resolver, args \\ nil) when is_atom(resolver) do | ||
| resolver.start(args) | ||
| end |
There was a problem hiding this comment.
not sure this function is needed
There was a problem hiding this comment.
This PR is still a draft, but the idea is that certain resolvers may need specific initialization, for example when their backend is a GenServer, as is the case with the DNS resolver, which is why this function exists.
There was a problem hiding this comment.
It's just that one could easily just call resolver.start(args) directly
There was a problem hiding this comment.
It's just that one could easily just call
resolver.start(args)directly
I will need to interact a little more to know if this is really a fact, I will bring you news soon about this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.