Add a benchmark to analyze performance on consequtive calls#20
Open
lessless wants to merge 4 commits intoelixir-inspector:masterfrom
Open
Add a benchmark to analyze performance on consequtive calls#20lessless wants to merge 4 commits intoelixir-inspector:masterfrom
lessless wants to merge 4 commits intoelixir-inspector:masterfrom
Conversation
Author
|
It seems that I missinterpreted Benchee results - there is no performance degradation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
This PR is a result of trying to understand UAInspector performance. The first change is just a convinience - it points data lookup path to a default download directory.
The second one is a test that will call
UAInspector.parse/1on an elements of a list. I don't yet know why butua_inspectorperformance degrades when it's being consequentively called on a list with even 10 elements.Also performance on data provided in bench scripts doesn't correspond with the one I observed the other day. Fortunatelly it was possible to reproduce the issue with sample data from https://github.com/51Degrees/Device-Detection
mix bench.parse