-
Notifications
You must be signed in to change notification settings - Fork 351
feat: add markdown support #2146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
… default formatters to include markdown. Adjust CLI and documentation to reflect changes in formatter options.
Thank you @yordis! I think the original pull request can be broken into three:
I think approaching it in steps should help the rebasing process and review. WDYT? |
@josevalim it is late for me (3AM), let me work on that then tomorrow.
If you dont mind to share some links to prev comments, or over all your thoughts, otherwise, I will figure it out |
@yordis you can see it in this PR, where epub.ex was accessing HTML directly and now it is extracted into a separate ExDoc.Formatter module :) Ideally, neither Epub nor Markdown modules should access the HTML one. |
I tried to merge main in ... I got lost to say the least |
@josevalim are you Ok with merging a module that could be unused but unit tested? I am getting lost doing this in chunk to be honest |
No description provided.