Skip to content

Conversation

yordis
Copy link
Contributor

@yordis yordis commented Sep 29, 2025

No description provided.

@yordis yordis changed the title yordis/md formatter feat: add markdown support Sep 29, 2025
@josevalim
Copy link
Member

Thank you @yordis! I think the original pull request can be broken into three:

  1. Refactor the EPUB and HTML to extract shared logic
  2. Effective generation of Markdown pages
  3. Add Copy as Markdown button

I think approaching it in steps should help the rebasing process and review. WDYT?

@yordis
Copy link
Contributor Author

yordis commented Sep 29, 2025

@josevalim it is late for me (3AM), let me work on that then tomorrow.

Refactor the EPUB and HTML to extract shared logic

If you dont mind to share some links to prev comments, or over all your thoughts, otherwise, I will figure it out

@josevalim
Copy link
Member

@yordis you can see it in this PR, where epub.ex was accessing HTML directly and now it is extracted into a separate ExDoc.Formatter module :) Ideally, neither Epub nor Markdown modules should access the HTML one.

@yordis
Copy link
Contributor Author

yordis commented Oct 2, 2025

I tried to merge main in ... I got lost to say the least

@yordis
Copy link
Contributor Author

yordis commented Oct 2, 2025

@josevalim are you Ok with merging a module that could be unused but unit tested? I am getting lost doing this in chunk to be honest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants