This repository was archived by the owner on Jan 7, 2024. It is now read-only.
Fixed Bug which leads to use of wrong module settings on config key duplicates#46
Open
DirkBaumeister wants to merge 2 commits intoellisv:1.2from
Open
Fixed Bug which leads to use of wrong module settings on config key duplicates#46DirkBaumeister wants to merge 2 commits intoellisv:1.2from
DirkBaumeister wants to merge 2 commits intoellisv:1.2from
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I fixed a bug which leaded to use of wrong module settings in the fix states command.
The problem was:
The oxconfig object initializes the module settings in a global array called _aConfigParams. In this array is no mapping to the modules. If the case is present that two module have keys with the exact same name then it happens that one of the modules get the setting of the other module on fix states.
With my changes this bug is resolved.
I did the following:
To be honest: This leads to a bad design of the oxconfig object structure because they concat all the params in array without an sublevel of modules.