Fix debugger virtualization #140
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lydell
commented
Jun 1, 2025
| @@ -46,7 +46,6 @@ var _Debugger_element = F4(function(impl, flagDecoder, debugMetadata, args) | |||
| function(sendToApp, initialModel) | |||
| { | |||
| var view = impl.__$view; | |||
| var title = __VirtualDom_doc.title; | |||
There was a problem hiding this comment.
This variable was unused. I stumbled upon it while doing the change just below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the debugger popup, the whole
documentis accidentally passed to__VirtualDom_virtualize, instead ofdocument.body. The code happens to work anyway. However, in elm/virtual-dom#187 that results in the debugger popup being a blank page, due to the virtualization fixes in that PR.This PR fixes this oversight, passing
.bodyto the virtualization as intended.elm/virtual-dom#187 still works without this PR, because I added a special case there. Basically,
if (node === document) { node = document.body; }. This is so that elm/virtual-dom#187 isn’t a breaking change (installing that but not this fix in elm/browser would lead to a broken debugger). I still felt like it was worth fixing this problem in the “right” place, too.Note to those following along: This PR is included in https://github.com/lydell/browser/tree/safe, which is part of https://github.com/lydell/elm-safe-virtual-dom.