Skip to content

mint - drop seed in keyset table #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
elnosh wants to merge 1 commit into
base: main
Choose a base branch
from
Open

mint - drop seed in keyset table #143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions mint/mint.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,12 +129,10 @@ func LoadMint(config Config) (*Mint, error) {
}
mint.activeKeyset = keyset
mint.keysets[keyset.Id] = *keyset
hexseed := hex.EncodeToString(seed)
activeDbKeyset := storage.DBKeyset{
Id: keyset.Id,
Unit: keyset.Unit,
Active: true,
Seed: hexseed,
DerivationPathIdx: keyset.DerivationPathIdx,
InputFeePpk: keyset.InputFeePpk,
}
Expand Down Expand Up @@ -1432,12 +1430,10 @@ func (m *Mint) RotateKeyset(fee uint) (*nut02.Keyset, error) {

m.keysets[newKeyset.Id] = *newKeyset

hexseed := hex.EncodeToString(seed)
activeDbKeyset := storage.DBKeyset{
Id: newKeyset.Id,
Unit: newKeyset.Unit,
Active: true,
Seed: hexseed,
DerivationPathIdx: newKeyset.DerivationPathIdx,
InputFeePpk: newKeyset.InputFeePpk,
}
Expand Down
1 change: 1 addition & 0 deletions mint/storage/sqlite/migrations/000011_drop_keyset_seed.down.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ALTER TABLE keysets ADD COLUMN seed TEXT;
1 change: 1 addition & 0 deletions mint/storage/sqlite/migrations/000011_drop_keyset_seed.up.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
ALTER TABLE keysets DROP COLUMN seed;
5 changes: 2 additions & 3 deletions mint/storage/sqlite/sqlite.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,8 +132,8 @@ func (sqlite *SQLiteDB) GetSeed() ([]byte, error) {

func (sqlite *SQLiteDB) SaveKeyset(keyset storage.DBKeyset) error {
_, err := sqlite.db.Exec(`
INSERT INTO keysets (id, unit, active, seed, derivation_path_idx, input_fee_ppk) VALUES (?, ?, ?, ?, ?, ?)
`, keyset.Id, keyset.Unit, keyset.Active, keyset.Seed, keyset.DerivationPathIdx, keyset.InputFeePpk)
INSERT INTO keysets (id, unit, active, derivation_path_idx, input_fee_ppk) VALUES (?, ?, ?, ?, ?)
`, keyset.Id, keyset.Unit, keyset.Active, keyset.DerivationPathIdx, keyset.InputFeePpk)

return err
}
Expand All @@ -153,7 +153,6 @@ func (sqlite *SQLiteDB) GetKeysets() ([]storage.DBKeyset, error) {
&keyset.Id,
&keyset.Unit,
&keyset.Active,
&keyset.Seed,
&keyset.DerivationPathIdx,
&keyset.InputFeePpk,
)
Expand Down
1 change: 0 additions & 1 deletion mint/storage/storage.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ type DBKeyset struct {
Id string
Unit string
Active bool
Seed string
DerivationPathIdx uint32
InputFeePpk uint
}
Expand Down