Open
Conversation
murbans1
force-pushed
the
cleanup_configs
branch
from
bebbd51 to
ed63b8c
Compare
murbans1
force-pushed
the
cleanup_configs
branch
from
76743c3 to
0dfaf5e
Compare
selvik
reviewed
Mar 19, 2025
| relevant_docs, | ||
| llm_server_url, | ||
| sql_search_db_and_model_path, | ||
| alpha, |
There was a problem hiding this comment.
Would we able to replace alpha with weaviate settings here? And also use the sql_search_settings for the other parameters?
selvik
reviewed
Mar 19, 2025
| llm_server_url, | ||
| sql_search_db_and_model_path, | ||
| alpha, | ||
| max_context_length, |
There was a problem hiding this comment.
max_context_length could also be added to llm_settings because it defines how much of the total possible context length of the LLM we will be using.
selvik
reviewed
Mar 19, 2025
| hybrid_search_settings = HybridSearchSettings() | ||
| llm_settings = LlmSettings() | ||
| sql_search_settings = SqlSearchSettings() | ||
|
|
There was a problem hiding this comment.
This style of setup looks great and makes it so much easier to read!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define config objects to make env variable handling easier.