Skip to content

Joint trajectory#52

Open
zaynabahmad wants to merge 9 commits intoelsayedelsheikh:mainfrom
zaynabahmad:joint_trajectory
Open

Joint trajectory#52
zaynabahmad wants to merge 9 commits intoelsayedelsheikh:mainfrom
zaynabahmad:joint_trajectory

Conversation

@zaynabahmad
Copy link

No description provided.

${visualization_msgs_TARGETS}
${moveit_msgs_TARGETS}
${moveit_visual_tools_TARGETS}
# ${moveit_visual_tools_TARGETS}
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not required

Suggested change
# ${moveit_visual_tools_TARGETS}

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we won’t need this package so I think it’s better to remove it for now to avoid any potential issues.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we won’t need this package so I think it’s better to remove it for now to avoid any potential issues.

Agreed! I meant let's remove the line entirely

<depend>moveit_ros_planning</depend>
<depend>moveit_ros_planning_interface</depend>
<depend>moveit_visual_tools</depend>
<!-- <depend>moveit_visual_tools</depend> -->
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto

Suggested change
<!-- <depend>moveit_visual_tools</depend> -->

find_package(visualization_msgs REQUIRED)
find_package(moveit_msgs REQUIRED)
find_package(moveit_visual_tools REQUIRED)
# find_package(moveit_visual_tools REQUIRED)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as below

Suggested change
# find_package(moveit_visual_tools REQUIRED)

Comment on lines +129 to +130
move_group_interface_->stop();
move_group_interface_->clearPoseTargets();
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to ensure that any previous motion or targets are cleared before planning a new trajectory,

<root main_tree_to_execute="MainTree">
<BehaviorTree ID="MainTree">
<Sequence>
<ComputeAndSendTrajectory/>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep this a planning action only following the current grab2 schema

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just for testing purposes, to quickly check the node functionality, this file should be removed.

zaynabahmad and others added 3 commits December 22, 2025 10:35
Co-authored-by: ElSayed ElSheikh <elsayed.elsheikh97@gmail.com>
Co-authored-by: ElSayed ElSheikh <elsayed.elsheikh97@gmail.com>
@elsayedelsheikh
Copy link
Owner

@zaynabahmad use pre-commit run -a to solve linting issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants