Open
Conversation
166d5f1 to
9516921
Compare
Author
|
It might make more sense to add this node to the tiago_demos package rather than keeping it in grab or what do you think? @elsayedelsheikh |
Owner
Totally! I've got an open PR in Tiago with a BT plugin called SetTargetUsingArUcoMarker and asked for your review a couple days ago. |
Author
Okey, I missed that this was already included in the PR. I’ll remove the package and keep only the BT plugin. |
9516921 to
702a99a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a new Detect2DMarker Behavior Tree plugin that consumes Detection2DArray messages and selects the nearest 2D marker.
Since the current ArUco node does not publish Detection2DArray, an adapter node is required to convert ArUco outputs to this message type before using the plugin