fix: convert fee estimates from BTC/kB to sat/vB#8
Merged
Conversation
douglaz
force-pushed
the
fix/fee-estimates-sat-vb
branch
from
e3e5cc6 to
47b98d7
Compare
Bitcoin Core's estimatesmartfee returns BTC/kB, but esplora API expects sat/vB. Fixed by using to_sat() and dividing by 1000. Also fixed the default fallback from 0.0001 BTC/kB to 1.0 sat/vB. Added: - Unit test for fee rate conversion formula - Bash tests to verify fee values are in sat/vB range - Bash test to compare fee estimates with blockstream
douglaz
force-pushed
the
fix/fee-estimates-sat-vb
branch
from
47b98d7 to
7ae3341
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
estimatesmartfeereturns BTC/kB, converted usingto_sat() / 1000Before (broken)
{"1": 0.00001198, "2": 0.00001198, ...}After (correct)
{"1": 1.198, "2": 1.198, ...}Test plan