Update ShaderPrecompiler.gd to work with 4.3#1
Open
UserDotCpp wants to merge 1 commit intoelvisish:mainfrom
Open
Update ShaderPrecompiler.gd to work with 4.3#1UserDotCpp wants to merge 1 commit intoelvisish:mainfrom
UserDotCpp wants to merge 1 commit intoelvisish:mainfrom
Conversation
As it was, it triggers the error: Invalid call. Nonexistent function 'get_surface_material_count' in base 'MeshInstance3D'. If I´m understanding the code, the "for" in line 36 looks for the materials of the mesh, but since the "mesh" is a MeshInstance3D(line 34) and not a proper mesh the code checks for any surface_override_material and then checks for the proper mesh materials. Was this intended? or is just a change in Godot 4.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As it was, it triggers the error:
Invalid call. Nonexistent function 'get_surface_material_count' in base 'MeshInstance3D'.
If I´m understanding the code, the "for" in line 36 looks for the materials of the mesh, but since the "mesh" is a MeshInstance3D(line 34) and not a proper mesh the code checks for any surface_override_material and then checks for the proper mesh materials.
Was this intended? or is just a change in Godot 4.3