Open
Conversation
skullim
commented
Nov 10, 2024
| InfixFilter::StartsWth(s) => infix.starts_with(s), | ||
| InfixFilter::Equls(s) => infix.eq(s), | ||
| InfixFilter::None => false, | ||
| InfixFilter::None => true, |
Author
There was a problem hiding this comment.
@emabee I was not sure about semantics of None variant, should it filter all or none? If former then I would create a new variant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I created a draft that allows defining a user-specific infix. This has a use case when e.g. there is some external tool that expects the log files to have a certain name.
There are probably some corner cases still to be handled and some work to split the functionality into separate/different files. This can be done once the general idea is accepted.
I think it would be good to also handle "_" separator, but it seems it requires quite some work.