Skip to content

Conversation

@poutsma
Copy link
Contributor

@poutsma poutsma commented Oct 30, 2025

This commit introduces a way to filter which properties are included when creating an object with the PromptRunner, via a predicate.

@poutsma poutsma requested a review from johnsonr October 30, 2025 15:54
@poutsma
Copy link
Contributor Author

poutsma commented Oct 30, 2025

This PR resolves #929, by filtering the JSON schema that is prompted to the LLM, so that only the desired properties show up in the resulting JSON.

This commit introduces PrompRunner::withPropertyFilter, a way to filter
which properties are included when creating an object with the
PromptRunner, via a predicate.

Signed-off-by: Arjen Poutsma <poutsma@mac.com>
@poutsma
Copy link
Contributor Author

poutsma commented Oct 31, 2025

Added tests

@poutsma poutsma marked this pull request as ready for review October 31, 2025 13:42
@igordayen
Copy link
Contributor

igordayen commented Oct 31, 2025

Arjen, may i suggest. 2 newly added artifacts, namely FilteringJackson... and JacksonOutput... seem not having dependency on other agent-api artifacts and would qualify for reusable cross embabel ecosystem "commons", specificaly as addition to module: embabel-common-ai. could you please review whether it makes sense to rellocate to "commons". thank you

@johnsonr johnsonr merged commit 19d4505 into embabel:main Nov 1, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants