Skip to content

Comments

[DO NOT MERGE] Claude code context file added, as well as new commands#58

Open
hjkmarshall wants to merge 2 commits intomainfrom
claude-code-test
Open

[DO NOT MERGE] Claude code context file added, as well as new commands#58
hjkmarshall wants to merge 2 commits intomainfrom
claude-code-test

Conversation

@hjkmarshall
Copy link
Contributor

@hjkmarshall hjkmarshall commented Jan 26, 2026

Claude-built dimension picker added, for review

Why is this pull-request needed?

Provide a high-level pull-request description of why this pull request is needed. This information will be used
by reviewers to understand the context of your pull-request.

Main changes

Describe the main changes in this pull-request in more detail.

Test evidence

Provide test evidence that the pull-request changes work as expected.

Summary by CodeRabbit

  • New Features
    • Added DimensionSelectFieldPro component, a dimension selector with auto-select functionality that automatically selects the first available dimension when no selection is provided and the field is not clearable.

✏️ Tip: You can customize this high-level summary in your review settings.

Claude-built dimension picker added, for review
@coderabbitai
Copy link

coderabbitai bot commented Jan 26, 2026

Important

Review skipped

Auto incremental reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review

Walkthrough

Addition of Claude guidance documentation for repository standards and workflows, combined with introduction of a new DimensionSelectFieldPro embeddable component comprising a React component wrapper and corresponding embeddable descriptor with input/output mapping.

Changes

Cohort / File(s) Summary
Claude Guidance Documentation
.claude/claude.md, .claude/commands/create-component.md, .claude/commands/improve-commands.md
Comprehensive guidance for Claude Code usage including project overview, build/dev commands, code conventions, architectural patterns, and structured templates for component creation and command improvement processes.
DimensionSelectFieldPro Component
src/components/editors/DimensionSelectFieldPro/index.tsx, src/components/editors/DimensionSelectFieldPro/DimensionSelectFieldPro.emb.ts
New embeddable component for dimension selection. React component renders EditorCard with SingleSelectField, auto-selects first dimension when non-clearable, supports dimension/null onChange. Embeddable descriptor defines inputs (dimension + granularity), events, and value mapping with noFilter fallback.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description includes the required template structure but the main content sections are left as placeholder text rather than filled with concrete details about the changes. Fill in 'Why is this pull-request needed?', 'Main changes', and 'Test evidence' sections with actual details about the dimension picker and Claude context additions.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title directly reflects the main changes: addition of Claude code context file and new commands, with the [DO NOT MERGE] flag indicating work-in-progress status.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In @.claude/claude.md:
- Around line 47-63: In .claude/claude.md update the markdown code fence that
wraps the repository tree to include a language tag (e.g., change the opening
"```" to "```text") so the block is labeled and MD040 is satisfied; locate the
block shown under the src/ tree and only modify the opening fence to include
"text" (no other content changes).

Comment on lines +47 to +63
```
src/
├── components/
│ ├── charts/ # Chart components (bars/, pies/, lines/, shared/)
│ ├── editors/ # Form field editors & date pickers
│ ├── types/ # Component-specific types
│ └── utils/ # Component utilities
├── editors/ # Standalone editors (ColorEditor)
├── theme/
│ ├── formatter/ # Data formatting (decimals, currency)
│ ├── i18n/translations/ # Locale files (en.ts, de.ts, etc.)
│ ├── styles/ # CSS variables, themes
│ └── theme.types.ts # Theme type definitions
├── assets/ # Icons and fonts
├── types/ # Global shared types
└── utils.ts/ # Global utilities (color, date, data, object, cache)
```
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Add a language tag to the architecture fence. This satisfies MD040 and keeps lint clean.

✏️ Suggested fix
-```
+```text
 src/
 ├── components/
 │   ├── charts/           # Chart components (bars/, pies/, lines/, shared/)
 │   ├── editors/          # Form field editors & date pickers
 │   ├── types/            # Component-specific types
 │   └── utils/            # Component utilities
 ├── editors/              # Standalone editors (ColorEditor)
 ├── theme/
 │   ├── formatter/        # Data formatting (decimals, currency)
 │   ├── i18n/translations/  # Locale files (en.ts, de.ts, etc.)
 │   ├── styles/           # CSS variables, themes
 │   └── theme.types.ts    # Theme type definitions
 ├── assets/               # Icons and fonts
 ├── types/                # Global shared types
 └── utils.ts/             # Global utilities (color, date, data, object, cache)
-```
+```
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)

47-47: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

🤖 Prompt for AI Agents
In @.claude/claude.md around lines 47 - 63, In .claude/claude.md update the
markdown code fence that wraps the repository tree to include a language tag
(e.g., change the opening "```" to "```text") so the block is labeled and MD040
is satisfied; locate the block shown under the src/ tree and only modify the
opening fence to include "text" (no other content changes).

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
18.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant