fix(engine): improve drone stability and update platform validation schema#2
Merged
srpatcha merged 1 commit intoembeddedos-org:masterfrom Apr 17, 2026
Conversation
7915337 to
b98c283
Compare
srpatcha
approved these changes
Apr 17, 2026
Member
srpatcha
left a comment
There was a problem hiding this comment.
LGTM - math.hypot fix, schema updates, code dedup, and ruff cleanup all look good. Net code reduction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactored the drone navigation distance logic to use
math.hypotfor better numerical stability. While testing these changes, I noticed the CI was failing because the validation schema was missing several architectures and classes (like tricore, mips, automotive, mobile) that are actively used in theplatforms/directory.Type of Change
Changes
math.hypot(dlat, dlon)in drone simulator to prevent precision issues.VALID_ARCHESandVALID_CLASSESineosim/core/schema.pyto match real platform definitions.ruffto address existing formatting errors.Testing
pytest)Pre-Submission Checklist
Related Issues
None.
Screenshots / Logs
Local test run:
291 passed, 3 skipped in 1.41sAdditional Notes
The schema updates were necessary because the
test_validate_all_real_platformstest was failing on every real platform due to the outdated allowed lists inschema.py. I also spent some time cleaning up the duplicated code blocks in the engine modules that I stumbled upon while debugging.