Open
Conversation
Bug?
Changed the type of the value parameter of the send method from 'int' to 'unsigned char'. Given only 8 bit's is ever transmitted over the wire 'int'
could cause confusion.
Added conditional value checks to several functions to validate params.
Efficieny enhancement
By moving the fileopen processes to the setAddress and setDevice methods we can negate the need to repetively open
and close the file during read and write operations.
setAddress and setDeviceFile now return 1 or -1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've created an abstract class called gnublin_driver. Currently, I'm only moved the error handling items : error_flag, ErrorMessage, getErrorMessage etc. This will eliminate duplicate code in each class and allow for faster enhancements.
The onError() method is provided as pure virtual method from the driver class. Overloading this method provides a simple way to implement custom functionality per driver type that is automatically executed when the setErrorMessage() method is called.