Skip to content

profile options would not work for deploy:list #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

profile options would not work for deploy:list #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e795ee9
add profile readConfig
st-h May 15, 2020
6471bf9
fix profile param would not work when listing revisions
st-h May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,18 +15,19 @@ function _list(opts) {
let profile = opts.profile;
let manifestKey = opts.manifestKey

let client = new AWS.S3({
accessKeyId,
secretAccessKey,
region
});

if (profile) {
console.log('using profile: ' + profile);
AWS.config.credentials = new AWS.SharedIniFileCredentials({
profile: profile
});
}

let client = new AWS.S3({
accessKeyId,
secretAccessKey,
region
});

let listObjects = RSVP.denodeify(client.listObjects.bind(client));
let getObject = RSVP.denodeify(client.getObject.bind(client));

Expand All @@ -40,11 +41,12 @@ function _list(opts) {
.then((current) => {
return { revisions: revisionsResults, current };
})
.catch(() => {
.catch((error) => {
console.error('failed to get revisions: ' + error);
return { revisions: revisionsResults, current: { Body: '{}'} };
})
.then((result) => {
if (result.revisions.length < 1) {
if (!result.revisions || result.revisions.length < 1) {
return { revisions: [] };
}

Expand Down Expand Up @@ -182,14 +184,15 @@ module.exports = {
let archivePrefix = this.readConfig('archivePrefix');
let bucket = this.readConfig('bucket');
let region = this.readConfig('region');
let profile = this.readConfig('profile');
let manifestKey = this.readConfig('manifestKey');
let awsPrefix = this.readConfig('awsPrefix');

archivePrefix = awsPrefix ? `${awsPrefix}/${archivePrefix}` : archivePrefix;
manifestKey = awsPrefix ? `${awsPrefix}/${manifestKey}` : manifestKey;

let opts = {
accessKeyId, secretAccessKey, archivePrefix, bucket, region, manifestKey
accessKeyId, secretAccessKey, archivePrefix, bucket, region, profile, manifestKey
};

return _list(opts)
Expand Down Expand Up @@ -219,7 +222,7 @@ module.exports = {
accessKeyId, secretAccessKey, archivePrefix, bucket, region, profile, manifestKey
};

return _list(opts, this)
return _list(opts)
.then((data) => {
let revisions = data.revisions;
revisions.forEach(r => {
Expand Down