Adds option to prevent loader.js modifying export #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
July 26, 2017 10:15
…port This property allows for an immediate option to remove the functionality that mutates the module exports (ember-cli#114) and allows for a deprecation cycle when maintainers are ready to do so Workaround for ember-cli#114
mlunoe
force-pushed
the
mlunoe/optional-default-export-creation
branch
from
3c52f6b to
005756f
Compare
Contributor
|
released as v4.6.0 🎉 |
Author
|
Wow! Thanks for the fast turnaround! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a workaround for #114
Adding an option to enable(default)/disable
makeDefaultExport, which mutates the module exports will allow for us to avoid this issue immediately and for maintainers to start a deprecation cycle when ready.Related to PR: #128