-
Notifications
You must be signed in to change notification settings - Fork 30
Update execa to v6 (and update scripts to ESM) #502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
mansona
wants to merge
3
commits into
master
Choose a base branch
from
update-execa
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| /* eslint-disable no-console */ | ||
| import { execa } from 'execa'; | ||
| import path from 'path'; | ||
|
|
||
| // resolved from the root of the project | ||
| const inputDir = path.resolve('./test/fixtures/without-telemetry/input'); | ||
| const binPath = path.resolve('./bin/cli.js'); | ||
| const execOpts = { cwd: inputDir, stderr: 'inherit' }; | ||
|
|
||
| console.log('running codemod'); | ||
|
|
||
| const codemod = execa(binPath, ['app'], execOpts); | ||
| codemod.stdout.pipe(process.stdout); | ||
| await codemod; | ||
|
|
||
| console.log('codemod complete'); | ||
|
|
||
| console.log('comparing results'); | ||
|
|
||
| try { | ||
| await execa('diff', ['-rq', './app', '../output/app'], execOpts); | ||
| } catch (e) { | ||
| console.error('codemod did not run successfully'); | ||
| console.log(e); | ||
|
|
||
| process.exit(1); | ||
| } | ||
|
|
||
| console.log('codemod ran successfully! 🎉'); | ||
| process.exit(0); | ||
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| /* eslint-disable no-console */ | ||
|
|
||
| import { spawn } from 'child_process'; | ||
| import { execa } from 'execa'; | ||
| import path from 'path'; | ||
|
|
||
| // resolved from the root of the project | ||
| const inputDir = path.resolve('./test/fixtures/input'); | ||
| const execOpts = { cwd: inputDir, stderr: 'inherit' }; | ||
|
|
||
|
|
||
| console.log('installing deps'); | ||
|
|
||
| await execa('rm', ['-rf', 'node_modules'], execOpts); | ||
| await execa('yarn', ['install'], execOpts); | ||
|
|
||
| console.log('starting serve'); | ||
|
|
||
| // We use spawn for this one so we can kill it later without throwing an error | ||
| const emberServe = spawn('yarn', ['start'], execOpts); | ||
| emberServe.stderr.pipe(process.stderr); | ||
| emberServe.stdout.pipe(process.stdout); | ||
|
|
||
| await new Promise((resolve) => { | ||
| emberServe.stdout.on('data', (data) => { | ||
| if (data.toString().includes('Build successful')) { | ||
| resolve(); | ||
| } | ||
| }); | ||
| }); | ||
|
|
||
| console.log('running codemod'); | ||
|
|
||
| const codemod = execa( | ||
| '../../../bin/cli.js', | ||
| ['--telemetry', 'http://localhost:4200', 'app'], | ||
| execOpts | ||
| ); | ||
| codemod.stdout.pipe(process.stdout); | ||
| await codemod; | ||
|
|
||
| console.log('codemod complete, ending serve'); | ||
|
|
||
| emberServe.kill('SIGTERM'); | ||
|
|
||
| console.log('comparing results'); | ||
|
|
||
| try { | ||
| await execa('diff', ['-rq', './app', '../output/app'], execOpts); | ||
| } catch (e) { | ||
| console.error('codemod did not run successfully'); | ||
| console.log(e); | ||
|
|
||
| process.exit(1); | ||
| } | ||
|
|
||
| console.log('codemod ran successfully! 🎉'); | ||
| process.exit(0); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this test have actual assertions? Or is it like a smoke test?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so... unfortunatly the git diff didn't quite fiture out that this was a move-file change. I didn't alter the way the test was working, I'm just changing it to
.mjsto make it work with the new execa version.but from my understanding, this does have an "assertion". If you look at the bit that is calling diff on two folders: https://github.com/ember-codemods/ember-angle-brackets-codemod/pull/502/files#diff-f28f8437ce5be5f9a77df8786489b7522a29c3377687b4feb491253b7044a4e2R21 you'll see that it's testing the "app" folder against a known output folder. That comes from the fixtures folder: https://github.com/ember-codemods/ember-angle-brackets-codemod/tree/master/test/fixtures
essentially I've seen people setup codemod tests like this before and it's just testing an input folder against an expected output at the end, and if they match it's good 🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I hope that answers your question 🎉