Adds a RFC overview #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ember-rfcs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
kategengler
approved these changes
Sep 28, 2025
|
May need to add library to the prerender URLs |
mansona
reviewed
Sep 29, 2025
| const result = []; | ||
|
|
||
| for (let fileContents of data) { | ||
| result.push({number: fileContents.number, link: fileContents.rfcFile, title: fileContents.title,stage: fileContents.currentStage}); |
There was a problem hiding this comment.
since we're showing proposed things we won't always have a link to the rfcFile 🤔 should we also be exposing github links? what is the UX around this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new design we broke @kategengler's workflow of searching for an RFC in the side menu, so we now have the library page, showing the number, title and the stage. The only thing we need to figure out is the linking thing when RFCs are closed/merged or still in proposed stage. We can merge this now, and fix that later, or maybe I can fix it tomorrow.
