stop storing items in tmp/ directory, only copy bundled ember when no over-ride present #357
Open
alexblom wants to merge 1 commit intoemberjs:masterfrom
Open
stop storing items in tmp/ directory, only copy bundled ember when no over-ride present #357alexblom wants to merge 1 commit intoemberjs:masterfrom
alexblom wants to merge 1 commit intoemberjs:masterfrom
Conversation
only copy ember from gem when local over-ride / update not present
|
that'd help us a lot, especially given different permission systems than what's usually done with capistrano (don't ask). 👍 |
|
Oops, wrong bug/pull request. I'm actually finding that even when I do bundle exec rake -T I'm getting a tmp/ directory created. If I do it as the wrong user, all of a sudden I end up with an application that won't start. I don't think that simply loading the gem should start modifying the system. +1 to this pull to stop |
Author
|
Thanks tomash and CloCkWeRX. I don't really use Ember Rails anymore (moved to cli around the time of this commit) - would it be useful for me to update this pr to not have conflicts? |
|
Yes please :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every time Rails is initialized, ember-rails copies ember & ember-data from the local gem to tmp/ember-rails. When a user runs the ember-rails updater, versions are stored in /vendor/assets. If the user updates their ember gems instead, updated ember copies are placed in tmp/.
Changes:
Fixes #343 & possibly issues from #345.