Version 2, remove querystring and use node/browser inbuilt capabilities#46
Open
mikemaccana wants to merge 9 commits intoemerleite:masterfrom
Open
Version 2, remove querystring and use node/browser inbuilt capabilities#46mikemaccana wants to merge 9 commits intoemerleite:masterfrom
mikemaccana wants to merge 9 commits intoemerleite:masterfrom
Conversation
|
👍 for your effort but that has been already proposed. Check last line of |
|
I found all these change reasonable - even if they are 3 years old :-( @vladimyr I don't understand you "check last line" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @emerleite! This is only a small change to the code, but means the library is much smaller. All the tests still pass.
I've bumped the major version as it requires node 10.x as minimum (which is reasonable). I've added README and CHANGELOG entries too.