Issue19 : issue/16と issue/17 の変更内容をREADME.mdに反映#21
Open
yoshiyuki-140 wants to merge 1 commit intomainfrom
Open
Issue19 : issue/16と issue/17 の変更内容をREADME.mdに反映#21yoshiyuki-140 wants to merge 1 commit intomainfrom
yoshiyuki-140 wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
README.mdの古い情報を最新の実装に合わせて更新しました。主に、コマンドライン引数の仕様変更(2引数→3引数)に関する記述を修正し、機能説明の正確性を向上させました。
関連Issue
変更内容
<operator> <digits>から<operator> <left_digits> <top_digits>に修正left_digitsとtop_digitsを分けて記載2keta.pdfから2x1keta.pdf形式に修正git cloneコマンドの余分な閉じ括弧)を削除(タイポ修正)スクリーンショット
N/A(ドキュメント更新のみ)
変更前
変更後
動作確認項目
レビュー時の注意点
main.pyの実装(3つの位置引数:operator,left_digits,top_digits)と完全に一致していることを確認してください./sample/hyakumasu_たしざん_2x1keta.pdf)であることを確認してくださいその他
この変更により、README.mdと実際のコードの不整合が解消され、新規ユーザーが正しい使い方を理解できるようになります。