feat: introduce WithForceLocalReplySocket#278
Open
agranig wants to merge 1 commit intoemiago:mainfrom
Open
Conversation
When running a server in Docker or on a D-Nat'ed environment, force replies from this server from the local socket instead of trying a Via match. Otherwise replies will be sent from a new socket with a random port.
Owner
|
Hi Andreas. Thanks for looking at this. I unfortunately know what could trigger you todo this. I am not sure did you work on 1.0.0, but there was fix added in meantime It was made some buggy changes recently, but 1.0.0 was already pushed. Most of test worked due to client using Pls check last main branch and see this without fix. Then only feature that could be is reversed, forcing non local socket but this is already exposed with |
Author
|
Will do, give me some days to check that. Thanks for the hint! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running a server in Docker or on a D-Nat'ed environment, force replies from this server from the local socket instead of trying a Via match. Otherwise replies will be sent from a new socket with a random port.