Skip to content

fix: register dialog state read channel before sending 200 OK #285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emiago merged 1 commit into from
Feb 2, 2026
Merged

fix: register dialog state read channel before sending 200 OK #285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion dialog_server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,11 @@ func (s *DialogServerSession) WriteResponse(res *sip.Response) error {
}

s.setState(sip.DialogStateEstablished)

// Register dialog state read channel before transmitting 200 OK. This prevents a race
// condition where the ACK is received before we start waiting for it.
readStateCh := s.StateRead()

if err := tx.Respond(res); err != nil {
return err
}
Expand All @@ -322,7 +327,6 @@ func (s *DialogServerSession) WriteResponse(res *sip.Response) error {
defer timer.Stop()

state := sip.DialogStateEstablished
readStateCh := s.StateRead()
for state == sip.DialogStateEstablished {
select {
case <-timer.C:
Expand Down
Loading