-
Notifications
You must be signed in to change notification settings - Fork 52
Adding the constant StrictMode #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
I would rather handle this by adding support for the the missing fields. I presume you have code to handle the fields outside the library. |
|
Well that is the problem, no I don't. I receive them but I don't need them, the implemeted fields are enough for me. I understand the logic to be « blocking » in order to force to implement as many fields as we can, but this is very blocking for a production environment. Let's imagine Google adds a small change to the api in emergency (outside of the main release, but that impacts the return (not the request)), the library will return an error even if the asked operation succeeded. If the application (the code above the lib) code detects an error, it can understand that it is an update issue and misbehave. Another problem for me is that when I'm just updating bids (well ie others services/languages/components/companies are adding, setting criterions, adgroup_id ) and because they add a parameter not handled on the library, I missbehave in return. The logic is not IMHO safe as it should be. Perhaps handling the unknown fields differently (logging ? parts of the response ?) ? |
switch to 201506 - all tests are done by allan-simon
…ervice, and removed duplicated code by using pseudo-inheritance
…pport for trackingUrlTemplates/finalUrls in biddableCriterion
Ads are now refactored in a more usable/readable code, adding the Ad interface
made campaign serialization friendly with simple mutate operation
golint ad.go file
…ld value of destination url, which is supposed to be set to empty
…l_tracking_clone Emptying destination url when cloning
…remove the field on update
…o_string set tracking url template as pointer, as we may need empty string to …
we dont need Ad's URL as pointer
workaround bug in go xml serializer by removing omit empty from string pointer fields
as we can't SET an Ad (it is immutable) so we never need to send the value empty string and it makes the code more complex for no advantages
Partial Failure and Validate only
…lure_and_validate_only it's now possible to activate the soap headers
add adgroupcriterion as a response for bulk mutate
This constants aims to deactivate strict attitude if the library encounters a fields that is not managed by it. Because I'm operating on many type of google adwords entities, sometimes the library gives me an error only because it doesn't recognize a field that is not managed (but that have no impacts on work). It adds the UnknowError type too.