-
Notifications
You must be signed in to change notification settings - Fork 1
Simple improvements #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
pmanna
commented
Jan 22, 2015
- Made the generic sendRequestWithParameters: public, in order to deal with special requests (like session start)
- Added optional support for iOS 6
- Added simple persistent storage for requests when offline: requests are stored on disk when app becomes inactive and re-queued when connection is available again
…l with special requests (like session start) - Added optional support for iOS 6 - Added simple persistent storage for requests when offline
|
Hi @pmanna, thanks for your contribution! I've considered to add persistency of requests when offline, but I've decided to skip it because Google Analytics automatically drops requests that are older than 4 hours, and maybe that complexity wasn't worth. Anyway I'll look at your implementation. |
|
Thanks for your reply! However, I'm going to change the code again to ensure all the events are actually queued, not just the failed ones: let me know if that could be interesting for you, otherwise I'll keep them in my fork. Thank you again for your work on this matter, it spared me a few hours of coding! |
…imit throughput to GA servers and preventing drops at the same time.
- Shortened throttling interval
… characters (like '&') were NOT encoded properly by "stringByAddingPercentEscapesUsingEncoding:"
- Added better emulation of GA SDK 3 parameters - Added support for IDFA parameter
Repositioned mutex lock/unlock
- Better "weak self" handling in blocks