Gsm alphabet, 7bit message concatenation #3
Open
alexislg2 wants to merge 8 commits intoemilsedgh:masterfrom
Open
Gsm alphabet, 7bit message concatenation #3alexislg2 wants to merge 8 commits intoemilsedgh:masterfrom
alexislg2 wants to merge 8 commits intoemilsedgh:masterfrom
Conversation
Contributor
Author
|
Sorry, I need to fix a small bug |
Contributor
Author
|
bug fixed |
Contributor
Author
|
A last sing I want to fix:
for example if my message is 160 characters long and includes the € sign, then it is in fact 161 characters. So we need 2 separated messages. I'll fix this soon |
The encoding is separated in 2 steps now: * first: transform text into array of number, depending of the encoding * second: convert the array of number into a HEXA string
Contributor
Author
|
Everything is working fine Now. I don't plan new commits |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey I made 4 modifications (in 4 different commits)
-Use of GSM alphabet instead of ASCII for 7bit decryption. This allows in particular to use characters such as 'é', 'à', etc... with 7 bit
-bug fix: Remove the last character (undefined) when receiving 16bit message
-Use of GSM alphabet instead of ASCII for 7bit encryption
-The 7-bit messages concatenation was not working for me (only 16bit was working). And this is because you need to make padding after the header, as explained here http://en.wikipedia.org/wiki/Concatenated_SMS I recoded the encode7Bits to make it work
I tested all the 4 of them