Skip to content

Comments

Little changes )))#8

Open
jackkum wants to merge 17 commits intoemilsedgh:masterfrom
jackkum:master
Open

Little changes )))#8
jackkum wants to merge 17 commits intoemilsedgh:masterfrom
jackkum:master

Conversation

@jackkum
Copy link

@jackkum jackkum commented Oct 29, 2015

Ported from this https://github.com/jackkum/PHPPDU

Was too many "todo" in this module 😃

@emilsedgh
Copy link
Owner

Wow this is a huge change! Would you like to take over the module as maintainer?
And is it compatible with older version?

@jackkum
Copy link
Author

jackkum commented Oct 29, 2015

Why not, I can try.

Here is I made support 'generate' method: https://github.com/jackkum/pdu/blob/master/pdu.js#L81
here supporting 'parseStatusReport': https://github.com/jackkum/pdu/blob/master/pdu.js#L116
and here 'parse': https://github.com/jackkum/pdu/blob/master/pdu.js#L176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants