solvers: avoid specifying solver paths in define-runtime-path #278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On commands like `raco distribute`, paths under `define-runtime-path` will be copied over for distribution, which mandates their existence. Therefore, we should only use `define-runtime-path` with paths that we know for sure that they exist.
Contributor
|
FWIW, putting the solver binaries into Rosette did turn out to be the cleanest way to package up my project. It eliminated the need for extra logic telling Rosette where the packaged solvers are. I wouldn't have discovered this feature without Rosette forcing the binaries to be present. I do think that making the binaries optional is definitely the right idea, though perhaps there should be some specific documentation on packaging up projects that use Rosette, specifically suggesting that copying the binaries into Rosette is an easy route to packaging up the binaries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On commands like
raco distribute, paths underdefine-runtime-pathwill be copied over for distribution, which mandates their existence. Therefore, we should only usedefine-runtime-pathwith paths that we know for sure that they exist.