Skip to content

Evaluation of the first homework assignment#1

Open
danielhuppmann wants to merge 1 commit intomainfrom
evaluation
Open

Evaluation of the first homework assignment#1
danielhuppmann wants to merge 1 commit intomainfrom
evaluation

Conversation

@danielhuppmann
Copy link
Collaborator

@danielhuppmann danielhuppmann commented May 8, 2023

Overview

This is the evaluation for the first homework assignment.

There are no GitHub Actions workflows implemented in this repository to automatically execute the tests upon a pull request. I added a workflow via this pull request. The tests in function.py are executed successfully.

Grade

Satisfactory (3)

Observation and Comments

  1. It's better to put the copyright notice and badge at the top of the readme.
  2. The file main.py is empty, so the description in the Readme cannot be true.
  3. You have the tests and the actual functions to be tested in the same file, which I use in the workflow added in this PR.
  4. The tests in the test_functions.py are duplicates of the tests in functions.py, but they will not work because you did not import the methods.

@danielhuppmann danielhuppmann self-assigned this May 8, 2023
@danielhuppmann danielhuppmann requested a review from emir10a May 8, 2023 16:18
@danielhuppmann
Copy link
Collaborator Author

Feel free to merge or close this PR, no further action is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant