Feat: Implement Test Cases for Sub-CA Certificate Operations: Issue, Retrieve Information, Delete, and Retrieve PEM/DER Content#116
Open
sambodirce wants to merge 52 commits intodevelopfrom
Open
Conversation
added 18 commits
October 26, 2023 18:21
snhane
reviewed
Jan 13, 2024
Collaborator
snhane
left a comment
snhane
left a comment
There was a problem hiding this comment.
Check out the comment about the duplicate function.
And also review the inclusion of .pyc files
Comment on lines
+18
to
+38
| def generate_user_telephone(country_codes): | ||
| country_code = random.choice(country_codes) | ||
|
|
||
| if country_code == "Mozambique": | ||
| # Mozambique telephone numbers have the format +2588XXXXXXX | ||
| number = "+2588" + "".join([str(random.randint(0, 9)) for _ in range(7)]) | ||
| elif country_code == "South Africa": | ||
| # South Africa telephone numbers have the format +2783XXXXXXX | ||
| number = "+2783" + "".join([str(random.randint(0, 9)) for _ in range(7)]) | ||
| elif country_code == "Spain": | ||
| # Spain telephone numbers have the format +34XXXXXXXXX | ||
| number = "+34" + "".join([str(random.randint(0, 9)) for _ in range(9)]) | ||
| elif country_code == "EUA": | ||
| # USA telephone numbers have the format +1-XXX-XXX-XXXX | ||
| number = "+1-" + "".join([str(random.randint(0, 9)) for _ in range(3)]) + "-" + "".join( | ||
| [str(random.randint(0, 9)) for _ in range(3)]) + "-" + "".join( | ||
| [str(random.randint(0, 9)) for _ in range(4)]) | ||
| else: | ||
| number = "Country code not recognized." | ||
|
|
||
| return number |
Collaborator
There was a problem hiding this comment.
- This function is being repeated.
If possible could be defined in one place only
Collaborator
|
@sambodirce & @emjunior258 |
validate serial length
validate issuer length
… attributes endpoint removed
temporarily allow release of images in any pipeline
temporarily allow release of images in any pipeline 2
temporarily allow release of images in any pipeline 3
temporarily allow release of images in any pipeline - use meta tags
issue tls cert
…ior258/certeasy into feat/issue-tls-server-cert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add tests: