-
Notifications
You must be signed in to change notification settings - Fork 31
Add notebook: Introduction to Python #337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @despadam. Just a bunch of minor suggestions.
Co-authored-by: Aliaksandr Yakutovich <yakutovicha@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great content! Good work @despadam , i hope this will help many people, and we can get feedback from ppl after the first session. I have some smaller mostly optional changes.
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very much complete: thorough but not "too much" for complete beginners. Thanks @despadam! I've only two quite small suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only some minor details and it is good to go. Very good job @despadam. I really liked the last example where you use all the concepts you introduced before.
Co-authored-by: Fábio Lopes <33908066+fabioacl@users.noreply.github.com>
Already addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, @despadam!
Addresses: #282, #244