feat: new preg_escape() function
#20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new preg_escape() function that escapes PCRE delimiter characters in regular expression patterns, making it easier to safely use delimiters in PHP's PCRE functions.
Key changes:
- Implements
preg_escape()function with comprehensive delimiter validation and escaping logic - Adds extensive test coverage including edge cases and error conditions
- Updates documentation and autoload configuration
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/pcre.php | New file implementing the preg_escape() function with delimiter validation and escaping logic using a regex pattern to match unescaped delimiters |
| tests/Unit/pcreTest.php | Comprehensive test suite covering valid delimiters, error conditions, and edge cases for the new function |
| composer.json | Adds src/pcre.php to the autoload files array in alphabetical order |
| README.md | Documents the new PCRE Functions section with a link to the preg_escape() function |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AlwinGarside
force-pushed
the
feature/new-preg-escape-function
branch
from
c597a2a to
aaca777
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.