fix: adapt edit-message-github-diff test to sidebar reorganization#652
Open
empiricalrun[bot] wants to merge 8 commits intomainfrom
Open
fix: adapt edit-message-github-diff test to sidebar reorganization#652empiricalrun[bot] wants to merge 8 commits intomainfrom
empiricalrun[bot] wants to merge 8 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the failing test
edit message twice, wait for str_replace tool, and verify single commit via GitHub APIintests/edit-message-github-diff.spec.tswhich broke due to sidebar reorganization changes on theclaude/slack-add-sidenav-groupingbranch.Root Cause
The sidebar reorganization removed the workspace-specific "Sessions" link, leaving only one global "Sessions" link. Additionally, the session URL format changed from path-based (
/sessions/77894) to query-based (/sessions?id=77894).Changes Made
Line 15: Removed
.nth(1)from Sessions link selector since there's now only one Sessions link in the sidebarLine 21-22: Updated the new session button selector - the "+" button no longer has an accessible name, so we use a positional selector
Line 27: Updated the URL assertion to match both old and new URL formats
Test Results
✅ Test passes after changes: Report URL
The test completes successfully in ~85 seconds and correctly:
Related
claude/slack-add-sidenav-groupingbranchPR created from session #72258
Updated at 2026-01-22 08:20:34.259 UTC