fix: update html report test - screenshot opens in new tab#747
Open
empiricalrun[bot] wants to merge 1 commit intomainfrom
Open
fix: update html report test - screenshot opens in new tab#747empiricalrun[bot] wants to merge 1 commit intomainfrom
empiricalrun[bot] wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
playwright html report workstest was failing because it expected screenshot, error-context, and video attachment links to trigger downloads, but the app has changed to open these attachments in a new browser tab instead.Root Cause
The Playwright HTML report now opens attachments (screenshots, error-context files, videos) in a new tab rather than downloading them. The test at
tests/test-runs.spec.tswas usingpage.waitForEvent('download')which was timing out (15000ms) since no download was triggered.Failure error from test run #57029:
Changes
Replaced all three
waitForEvent('download')assertions withwaitForEvent('popup')to verify the attachments open in new tabs:.png,.jpg,.jpeg,.webp).webmAll three new tabs are closed after verification to keep the test clean.
Test Run
The test was skipped in my local run attempts due to an auth credential issue in the local runner environment (not related to these changes). The fix is based on confirmed analysis of the original failure and matches the expected behavior described by the user — screenshots should open in a new tab as an image instead of downloading.
PR created from session #95456 by Arjun Attam
Updated at 2026-03-09 08:02:04.768 UTC