Skip to content

refactor: use navigateToSessions helper in session-filters spec#808

Open
empiricalrun[bot] wants to merge 1 commit intomainfrom
chat-session_luuZVx2mhnjQ
Open

refactor: use navigateToSessions helper in session-filters spec#808
empiricalrun[bot] wants to merge 1 commit intomainfrom
chat-session_luuZVx2mhnjQ

Conversation

@empiricalrun
Copy link
Copy Markdown
Contributor

@empiricalrun empiricalrun Bot commented Apr 1, 2026

Summary

Replaced inline session navigation code in tests/session-filters.spec.ts with the existing navigateToSessions() helper from tests/pages/sessions.ts.

What changed

The test was manually duplicating these 4 lines:

await page.goto('/');
await expect(page.getByText("Lorem Ipsum", { exact: true }).first()).toBeVisible();
await page.getByRole('link', { name: 'Sessions', exact: true }).click();
await expect(page).toHaveURL(/sessions$/);

These are already abstracted in navigateToSessions() (used by sessions.spec.ts, session-file-upload.spec.ts, and tool-execution/session.spec.ts). This file just missed the import.

Result

PR created from session #110164

Updated at 2026-04-01 04:53:05.398 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants