refactor: extract navigateToToolsTab helper to pages/sessions.ts#890
Open
empiricalrun[bot] wants to merge 7 commits intomainfrom
Open
refactor: extract navigateToToolsTab helper to pages/sessions.ts#890empiricalrun[bot] wants to merge 7 commits intomainfrom
empiricalrun[bot] wants to merge 7 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Identified that
page.getByRole('tab', { name: 'Tools', exact: true }).click()was inlined 13 times across 3 spec files without being abstracted into a reusable helper.Change
Added a single
navigateToToolsTab(page: Page)helper totests/pages/sessions.tsand replaced all inline usages across:tests/tool-execution/session.spec.ts— 11 occurrences (with bothpageandsessionPage)tests/issues.spec.ts— 1 occurrencetests/my-sessions.spec.ts— 1 occurrenceWhy this is the right place
tests/pages/sessions.tsalready houses all session-detail navigation helpers (navigateToSessions,openReviewPanel,waitForFirstMessage, etc.). The Tools tab is a core part of the session detail view, making this a natural fit.No functional change
This is a pure refactor — no test logic was modified, only the navigation call was extracted to a named helper.
PR created from session #127322
Updated at 2026-05-01 04:56:38.190 UTC