refactor: extract waitForPullRequestCreated helper#892
Open
empiricalrun[bot] wants to merge 12 commits intomainfrom
Open
refactor: extract waitForPullRequestCreated helper#892empiricalrun[bot] wants to merge 12 commits intomainfrom
empiricalrun[bot] wants to merge 12 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracted a repeated inline assertion into a named helper function
waitForPullRequestCreatedintests/pages/sessions.ts.Problem
The pattern below appeared 7 times across 5 test files, always with the same 5-minute timeout:
Change
Added one helper to
tests/pages/sessions.ts:The optional
nthparameter handles the case insession-two-prs.spec.tswhere a second PR occurrence needs to be awaited (waitForPullRequestCreated(page, 1)).Files updated
tests/pages/sessions.tswaitForPullRequestCreatedhelpertests/merge-conflicts.spec.tstests/merge-conflicts-impacted-tests.spec.tstests/edit-message-branch-restore.spec.tstests/my-sessions.spec.tstests/session-two-prs.spec.tsnth(1))TypeScript compiles with no errors.
PR created from session #127680
Updated at 2026-05-02 04:55:21.855 UTC