refactor: use navigateToSessions helper in session-filters spec#894
Open
empiricalrun[bot] wants to merge 1 commit intomainfrom
Open
refactor: use navigateToSessions helper in session-filters spec#894empiricalrun[bot] wants to merge 1 commit intomainfrom
empiricalrun[bot] wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaced a manually duplicated 4-line navigation block in
tests/session-filters.spec.tswith the existingnavigateToSessionshelper fromtests/pages/sessions.ts.Before
After
The logic is identical to the
navigateToSessionshelper that already existed inpages/sessions.ts— this change simply removes the duplication and uses the shared abstraction.Test Result
✅ Test passed: Report
PR created from session #127897
Updated at 2026-05-04 04:52:46.219 UTC