Skip to content

refactor: use navigateToSessions helper in session-filters spec#894

Open
empiricalrun[bot] wants to merge 1 commit intomainfrom
chat-session_3dmsbtnypVYx
Open

refactor: use navigateToSessions helper in session-filters spec#894
empiricalrun[bot] wants to merge 1 commit intomainfrom
chat-session_3dmsbtnypVYx

Conversation

@empiricalrun
Copy link
Copy Markdown
Contributor

@empiricalrun empiricalrun Bot commented May 4, 2026

Summary

Replaced a manually duplicated 4-line navigation block in tests/session-filters.spec.ts with the existing navigateToSessions helper from tests/pages/sessions.ts.

Before

// Navigate to homepage
await page.goto('/');

// Wait for successful login
await expect(page.getByText("Lorem Ipsum", { exact: true }).first()).toBeVisible();

// Navigate to Sessions page
await page.getByRole('link', { name: 'Sessions', exact: true }).click();

// Wait for sessions page to load
await expect(page).toHaveURL(/sessions$/);

After

import { navigateToSessions } from "./pages/sessions";

await navigateToSessions(page);

The logic is identical to the navigateToSessions helper that already existed in pages/sessions.ts — this change simply removes the duplication and uses the shared abstraction.

Test Result

✅ Test passed: Report

PR created from session #127897

Updated at 2026-05-04 04:52:46.219 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants