Fix -sEXIT_RUNTIME in MINIMAL_RUNTIME build mode. #25321
+18
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inimal0 suite, e.g. minimal0.test_static_variable.
sbc100
approved these changes
Sep 19, 2025
sbc100
reviewed
Sep 19, 2025
There was a problem hiding this comment.
The throw exit(${code})code is not dependent onEXIT_RUNTIME` so maybe the catch here should not be either?
i.e. do we want the "silently suppress exit exception" to only happen when EXIT_RUNTIME is set? and otherwise we just let the exit exception propagate the top level?
Then it would increase code size for no benefit. If user is building with |
sbc100
reviewed
Sep 19, 2025
sbc100
approved these changes
Sep 19, 2025
sbc100
reviewed
Sep 22, 2025
| #if RUNTIME_DEBUG | ||
| dbg(`main() called ${e}.`); // e.g. "main() called exit(0)." | ||
| #endif | ||
| // Report to Module that the program exited. TODO: Find a way to not emit |
There was a problem hiding this comment.
Wrap this in #if expectToReceiveOnModule('onExit').
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix -sEXIT_RUNTIME in MINIMAL_RUNTIME build mode. Fixes 13 tests in minimal0 suite, e.g. minimal0.test_static_variable.