Add function emscripten_audio_context_sample_rate() #25352
+11
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Sep 22, 2025
| #if ASSERTIONS | ||
| assert(EmAudio[contextHandle], `Called emscripten_audio_context_sample_rate() with an invalid Web Audio Context handle ${contextHandle}`); | ||
| assert(EmAudio[contextHandle] instanceof (window.AudioContext || window.webkitAudioContext), `Called emscripten_audio_context_sample_rate() on handle ${contextHandle} that is not an AudioContext, but of type ${EmAudio[contextHandle]}`); | ||
| #endif |
There was a problem hiding this comment.
How about adding a getAudioContext(handle) helper that can take care of adding these assertions to all APIs that need to lookup a handler like this?
Then this would just be emscripten_audio_context_sample_rate: (handle) => getAudioContext(handle)['sampleRate'],
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that we have a function
emscripten_audio_context_quantum_size(EMSCRIPTEN_WEBAUDIO_T audioContext), also add a functionemscripten_audio_context_sample_rate(EMSCRIPTEN_WEBAUDIO_T audioContext)to easily get the sampling rate of the context graph.Will need to add some tests etc. though putting this up already to organize PRs.