Remove the redundant Web Audio Worklet bootstrap processor node #25354
+49
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
reviewed
Sep 23, 2025
| var currentFrame; | ||
| var currentTime; | ||
| var sampleRate; | ||
| var port; |
There was a problem hiding this comment.
This seems like very generic name. I wonder if we move these to audio-worklet-externs.js?
| assert(varargs); | ||
| #endif | ||
| (audioContext ? EmAudio[audioContext].audioWorklet.bootstrapMessage.port : messagePort).postMessage({'_wsc': funcPtr, args: readEmAsmArgs(sigPtr, varargs) }); | ||
| (audioContext ? EmAudio[audioContext].audioWorklet.port : messagePort).postMessage({'_wsc': funcPtr, args: readEmAsmArgs(sigPtr, varargs) }); |
There was a problem hiding this comment.
The var messagePort; was deleted from audio_worklet.js but I don't see it being added elsewhere. Should it still be referenced here, or should it be just port (i.e. globalThis.port)?
sbc100
reviewed
Sep 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the redundant Web Audio Worklet bootstrap processor node after WebAudio/web-audio-api#2456 has been fixed.