Optimize ENVIRONMENT_IS_WASM_WORKER check when building with Audio Worklets enabled #25364
+20
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rklets enabled, for a code size saving of 7 bytes.
sbc100
reviewed
Sep 23, 2025
src/shell_minimal.js
Outdated
|
|
||
| #if WASM_WORKERS | ||
| #if AUDIO_WORKLET | ||
| var ENVIRONMENT_IS_AUDIO_WORKLET = typeof AudioWorkletGlobalScope !== 'undefined'; |
There was a problem hiding this comment.
You can just use != here to save another byte.
We explicitly use == and != when the type of both the LHS and the RHS can only be strings (as in this case). See #16261 for more on this.
There was a problem hiding this comment.
The PR #25351 will cover that part. I'll land 25351 first, and then update this PR on top.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize ENVIRONMENT_IS_WASM_WORKER check when building with Audio Worklets enabled, for a code size saving of 7 bytes.
Before, Closure would emit:
Afterwards, it emits