-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Support JS symbols that are aliases of native ones #25376
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
ba4a633
to
055b225
Compare
055b225
to
a548beb
Compare
What happens if we ever want to try to remove the leading underscore from native functions? Will this start causing clashes? |
I don't think it makes the situation WRT removing underscores any worse. Already if you declare |
8e26776
to
4fc13c5
Compare
e02290a
to
ad368c1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks OK? TBH I'm not sure I really understand the JS linking system deeply enough to know whether this is really a good idea though.
This idea is that this allows us to have JS names that don't match the native symbol names. In particular this simplifies the memory and table export handling. I think this is needed for my ongoing work on dynamic linking, but it actually might not me. I can can hold off landing this and circle back parhaps if it proves truely necessary. |
If this is really an improvement on its own, then I think it's fine to add it. I just don't have a high confidence in my review. |
We can then use this mechanism to replace the hacky way to we map things like `memory` -> `wasmMemory` and `__indirect_function_table` => `wasmTable`.
ad368c1
to
11bdf33
Compare
We can then use this mechanism to replace the hacky way to we map things like
memory
->wasmMemory
and__indirect_function_table
=>wasmTable
.