Roll Emdawnwebgpu and repoint USE_WEBGPU tests at Emdawnwebgpu #25397
+205
−294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation to remove USE_WEBGPU entirely (emscripten-core#24265). Ideally these tests would live in Dawn, but we don't have a way to automate tests in the browser yet, so for the moment we'll keep them in Emscripten. DO NOT SUBMIT: Needs Emdawnwebgpu roll in order to pass
|
@lokokung PTAL |
lokokung
approved these changes
Sep 26, 2025
kainino0x
force-pushed
the
roll-and-repoint-tests
branch
2 times, most recently
from
a88588a to
ffb124d
Compare
kainino0x
force-pushed
the
roll-and-repoint-tests
branch
from
ffb124d to
d12517b
Compare
lokokung
approved these changes
Sep 26, 2025
kainino0x
force-pushed
the
roll-and-repoint-tests
branch
from
3b2d73d to
4c7bf8a
Compare
kainino0x
force-pushed
the
roll-and-repoint-tests
branch
from
4c7bf8a to
4f93d5f
Compare
sbc100
reviewed
Sep 29, 2025
|
|
||
| def test_webgpu_get_device_pthreads(self): | ||
| self.btest_exit('webgpu_get_device.cpp', cflags=['-Wno-error=deprecated', '-sUSE_WEBGPU', '-pthread']) | ||
| self.set_setting('NO_DEFAULT_TO_CXX', 0) # emdawnwebgpu uses C++ internally |
There was a problem hiding this comment.
What to do about this long term?
Is this some fundamental difference between the old and new implementation? The only one manged to avoid depending on libc++ library functions but the new one did not? Are folks who use this library simply bound to link with C++?
sbc100
reviewed
Sep 29, 2025
| raise Exception('Remote ports require Emscripten 4.0.10+.') | ||
|
|
||
|
|
||
| def clear(ports, settings, shared): |
There was a problem hiding this comment.
Can / should we update the port as a separate PR that we can land first?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation to remove USE_WEBGPU entirely (#24265). Ideally these tests would live in Dawn, but we don't have a way to automate tests in the browser yet, so for the moment we'll keep them in Emscripten.