Skip to content

Fix occasional segfault in WContainerWidget::widget called by WTableView::setHeaderHeight #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m-seibt wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix occasional segfault in WContainerWidget::widget called by WTableView::setHeaderHeight #238

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d51150a
Turn SF in WContainerWidget::widget into exception
m-seibt Feb 24, 2026
02d03af
Fix WTableView accessing nonexisting header widget
m-seibt Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Wt/WContainerWidget.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,6 +241,9 @@ int WContainerWidget::indexOf(WWidget *widget) const

WWidget *WContainerWidget::widget(int index) const
{
if (index < 0 || index >= children_.size())
throw Wt::WException("WContainerWidget::widget: index " + std::to_string(index)
+ " is out of range [0, " + std::to_string(children_.size()) + ")");
return children_[index];
}

Expand Down
8 changes: 6 additions & 2 deletions src/Wt/WTableView.C
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1315,8 +1315,12 @@ WWidget* WTableView::headerWidget(int column, bool contentsOnly)
result = headers_->widget(column - headerColumnsTable_->count());
}
} else
if (plainTable_ && column < plainTable_->columnCount())
result = plainTable_->elementAt(0, column)->widget(0);
if (plainTable_ && column < plainTable_->columnCount()) {
WTableCell *headerCell = plainTable_->elementAt(0, column);
if (headerCell->count() == 0)
return result;
result = headerCell->widget(0);
}

if (result && contentsOnly)
return result->find("contents");
Expand Down