Don't allow king to castle through or out of check

[CompuGeniusCode]

No description provided.

[emymin]

Thank you for the contribution!
There seems to be a bug generating legal moves for the king when placed under check while the conditions for castling are satisfied

rnb1kbnr/ppp3p1/8/7p/8/8/PPPPqPPP/RNB1K2R w KQkq - 0 1
This position is registered as a checkmate, however the king is able to capture the queen and exit check.
rnb1kbnr/pppp3p/6p1/8/8/7N/PPPPqPPP/RNBQK2R w KQkq - 0 1
Trying a similar position, it seems that indeed the fact that the king could capture the queen is not considered

1nbqkbnr/1ppppppp/8/p6Q/4r3/N6N/PPPP1PPP/R1B1K2R w KQka - 0 1
In this position, the king should be able to move left or right by one square to exit check, however oddly enough the board registers the moves king to C4 and king to G4 instead (which are very much illegal)

[CompuGeniusCode]

Were these bugs not there before my edit? I definitely remember coming across an issue where a king couldn't kill a queen that was attacking it.

[emymin]

It's possible there might be similar issues like that, the move generation really needs some proper automated testing.

However in the positions I mentioned, the current version behaves correctly (with the exception of also including castling as a valid move of course).

[CompuGeniusCode]

Hmm. I'll keep trying. I haven't looked yet - is there a way to start the board in a certain FEN besides standard starting pos for faster testing? I'm not up for creating automated testing rn, but st least that would make it faster.

[emymin]

The Board has a method to load FEN strings which it uses to lay out the board when starting a game, that part is also fairly untested but I think loading mid-game positions should be fine!