Enforce ruff rules using pre-commit

[DimitriPapadopoulos]

Use the pre-commit GitHub Action although:

this action is in maintenance-only mode and will not be accepting new features.

The alternative would be to give pre-commit.ci access to the repository.

Requires enabling GitHub Actions for this repository.

[kevina]

Set has a fixed overhead, for a small number of elements a tuple would be better.

[DimitriPapadopoulos]

I'm not sure that's true in practice:

$ python -m timeit -s 'l = ["remove", "transfer"]; "foo" in l'
50000000 loops, best of 5: 6.16 nsec per loop
$ python -m timeit -s 'l = ["remove", "transfer"]; "foo" in l'
50000000 loops, best of 5: 6.15 nsec per loop
$ python -m timeit -s 'l = ["remove", "transfer"]; "foo" in l'
50000000 loops, best of 5: 6.22 nsec per loop
$ python -m timeit -s 'l = ["remove", "transfer"]; "foo" in l'
50000000 loops, best of 5: 6.34 nsec per loop
$ python -m timeit -s 'l = ["remove", "transfer"]; "foo" in l'
50000000 loops, best of 5: 6.14 nsec per loop
$ python -m timeit -s 'l = ["remove", "transfer"]; "foo" in l'
50000000 loops, best of 5: 6.14 nsec per loop
$ 
$ python -m timeit -s 's = {"remove", "transfer"}; "foo" in s'
50000000 loops, best of 5: 6.16 nsec per loop
$ python -m timeit -s 's = {"remove", "transfer"}; "foo" in s'
50000000 loops, best of 5: 6.17 nsec per loop
$ python -m timeit -s 's = {"remove", "transfer"}; "foo" in s'
50000000 loops, best of 5: 6.19 nsec per loop
$ python -m timeit -s 's = {"remove", "transfer"}; "foo" in s'
50000000 loops, best of 5: 6.16 nsec per loop
$ python -m timeit -s 's = {"remove", "transfer"}; "foo" in s'
50000000 loops, best of 5: 6.15 nsec per loop
$ 

[kevina]

You tested with a list, not a tuple. In any case I still prefer using a tuple in these cases. Thank you.

[DimitriPapadopoulos]

Same with a tuple:

$ python -m timeit -s 'l = ("remove", "transfer"); "foo" in l'
50000000 loops, best of 5: 6.37 nsec per loop
$ python -m timeit -s 'l = {"remove", "transfer"}; "foo" in l'
50000000 loops, best of 5: 6.03 nsec per loop
$ 
$ python -m timeit -s 'l = ("remove", "transfer"); "foo" in l'
50000000 loops, best of 5: 6 nsec per loop
$ python -m timeit -s 'l = {"remove", "transfer"}; "foo" in l'
50000000 loops, best of 5: 6.02 nsec per loop
$ 
$ python -m timeit -s 'l = ("remove", "transfer"); "foo" in l'
50000000 loops, best of 5: 6.02 nsec per loop
$ python -m timeit -s 'l = {"remove", "transfer"}; "foo" in l'
50000000 loops, best of 5: 6.01 nsec per loop
$ 

[DimitriPapadopoulos]

I would suggest using prek as a drop-in replacement for pre-commit.

The associated j178/prek-action is fully maintained.