Skip to content

Fix: Segmentation fault on file open error #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ventZl wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix: Segmentation fault on file open error #11

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion hex2dfu.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ int main (int argc, char **argv) {
int targen_number = 0;
int i, c, vid =0x0483, pid = 0xdf11, ver = 0xffff;
char *tar0 = NULL, *tar0_lab = NULL, *out_fn = NULL;
FILE *inFile, *outFile;
FILE *inFile = NULL, *outFile = NULL;
unsigned char json_output = 0;
unsigned int max_address = 0x08200000;

Expand Down Expand Up @@ -149,6 +149,10 @@ int main (int argc, char **argv) {
#endif

inFile = fopen ( tar0, "r");
if (!inFile) {
perror("error: open input file");
return 1;
}
tar0_buf = ihex2bin_buf(&tar0_start_address, &tar0_len, inFile, max_address);
tar0_len = tar0_len + ((tar0_len & 0x07) ? (8 - (tar0_len & 0x07)) : 0);
fclose (inFile);
Expand Down Expand Up @@ -253,6 +257,11 @@ int main (int argc, char **argv) {

//write DFU to file
outFile = fopen (out_fn, "wb");
if (!outFile) {
perror("error: open output file");
return 1;
}

c = fwrite (dfu, dfu_len, 1, outFile);
fclose(outFile);
if (c != 1) {
Expand Down